Fix #99684 through autoref in write! macro with a two-phased borrows retrocompat workaround#100202
Closed
danielhenrymantilla wants to merge 3 commits intorust-lang:masterfrom
Closed
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99684, using the idea suggested over #99684 (comment) by @eddyb, and implemented by @dtolnay to test its viability.
On top of that, it does use a two phased borrows retrocompat workaround (imho, the
write!family of macros supporting two-phased borrows to begin with is quite surprising —could we have a FCW against it?).write!);EDIT: as it is implemented now, it should be quite robust and tackle the expected semantics 🙂